[dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

[Navin Srinivas]

Hi,

Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1,
but did not see PF crash on 20.11.3,
I'm seeing a crash on the secondary process when it receives packet on the
VF, but PF doesn't crash now on 20.11.3

So I suspect this is the patch which is fixing the issue on ICE secondary
process crash on PF.

Thanks & Regards,
Navin Srinivas

On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang at intel.com> wrote:

>
>
> > -----Original Message-----
> > From: Wang, Yixue <yixue.wang at intel.com>
> > Sent: Thursday, June 3, 2021 6:04 PM
> > To: Zhang, Qi Z <qi.z.zhang at intel.com>; Yang, Qiming
> > <qiming.yang at intel.com>
> > Cc: Zhang, Liheng <liheng.zhang at intel.com>; Dong, Yao
> > <yao.dong at intel.com>; dev at dpdk.org; stable at dpdk.org
> > Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary
> > process
> >
> > Hi, Qi
> >
> > I've tested this patch and it works.
> >
> > Best Regards,
> > Yixue.
> >
> > > -----Original Message-----
> > > From: Zhang, Qi Z <qi.z.zhang at intel.com>
> > > Sent: Monday, May 24, 2021 17:08
> > > To: Yang, Qiming <qiming.yang at intel.com>
> > > Cc: Zhang, Liheng <liheng.zhang at intel.com>; Wang, Yixue
> > > <yixue.wang at intel.com>; Dong, Yao <yao.dong at intel.com>; dev at dpdk.org;
> > > Zhang, Qi Z <qi.z.zhang at intel.com>; stable at dpdk.org
> > > Subject: [PATCH] net/ice: fix wrong data path selection in secondary
> > > process
> > >
> > > The flag use_avx2 and use_avx512 are defined as local variables, they
> > > will not be aware by the secondary process, then wrong data path is
> > > selected. Fix the issue by moving them into struct ice_adapter.
> > >
> > > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")
> > > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx")
> > > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")
> > > Cc: stable at dpdk.org
> > >
> > > Reported-by: Yixue Wang <yixue.wang at intel.com>
> > > Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
>
> Tested-by: Yixue Wang <yixue.wang at intel.com>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/stable/attachments/20220222/53e7bb12/attachment.htm>