[PATCH v2 2/2] app/testpmd:fix testpmd quit failure
Ferruh Yigit
ferruh.yigit at intel.com
Wed Feb 23 13:09:58 CET 2022
On 2/23/2022 11:32 AM, wenxuanx.wu at intel.com wrote:
> From: wenxuan wu <wenxuanx.wu at intel.com>
>
> When testpmd start ed with 1 pf and 2 vfs, testpmd quited while vfs
> were still alive would result in failure. Root cause is that pf had
> been released already but vfs were still accessing by func
> rte_eth_dev_info_get, which would result in heap-free-after-use error.
>
> By quitting our ports in reverse order to avoid this.And the order is
> guaranteed that vf are created after pfs.
>
> Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM")
> Cc: stable at dpdk.org
>
> Signed-off-by: wenxuan wu <wenxuanx.wu at intel.com>
> ---
> app/test-pmd/testpmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e1da961311..698b6d8cc4 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3384,12 +3384,12 @@ pmd_test_exit(void)
> #endif
> if (ports != NULL) {
> no_link_check = 1;
> - RTE_ETH_FOREACH_DEV(pt_id) {
> + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) {
The main problem with this patch was this logic,
can you please check comment on previous version?
> printf("\nStopping port %d...\n", pt_id);
> fflush(stdout);
> stop_port(pt_id);
> }
> - RTE_ETH_FOREACH_DEV(pt_id) {
> + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) {
> printf("\nShutting down port %d...\n", pt_id);
> fflush(stdout);
> close_port(pt_id);
More information about the stable
mailing list