[PATCH 19.11 v1 2/3] net/i40e: build failure with make and clang < 13

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon Jan 3 12:34:42 CET 2022


On Mon, Dec 20, 2021 at 12:21 PM Haiyue Wang <haiyue.wang at intel.com> wrote:
>
> Check the clang version before enabling '-Wno-unused-but-set-variable',
> otherwise it will have "error: unknown warning option".

Thanks, Queued for 19.11.11 as it improves some other recently added
compiler fixes and we'd want to avoid those breaking older clang
builds.

> https://reviews.llvm.org/D100581
>
> Bugzilla ID: 913
>
> Signed-off-by: Haiyue Wang <haiyue.wang at intel.com>
> ---
>  drivers/net/i40e/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile
> index d6ced28f3d..3f7565fbd6 100644
> --- a/drivers/net/i40e/Makefile
> +++ b/drivers/net/i40e/Makefile
> @@ -35,7 +35,9 @@ CFLAGS_BASE_DRIVER += -Wno-missing-field-initializers
>  CFLAGS_BASE_DRIVER += -Wno-pointer-to-int-cast
>  CFLAGS_BASE_DRIVER += -Wno-format-nonliteral
>  CFLAGS_BASE_DRIVER += -Wno-unused-variable
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION) -ge 13 && echo 1), 1)
>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> +endif
>  else
>  CFLAGS_BASE_DRIVER  = -Wno-sign-compare
>  CFLAGS_BASE_DRIVER += -Wno-unused-value
> --
> 2.34.1
>


-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd


More information about the stable mailing list