[PATCH] 5-make-release-commit: fix rstheader
Christian Ehrhardt
christian.ehrhardt at canonical.com
Tue Jan 11 08:51:57 CET 2022
On Mon, Jan 10, 2022 at 3:51 PM Kevin Traynor <ktraynor at redhat.com> wrote:
>
> On 07/01/2022 09:50, christian.ehrhardt at canonical.com wrote:
> > From: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> >
> > The printf magic fails trying to interpret "-" as option and thereby breaking
> > the top level headers.
> > printf: -%: invalid option
> > printf: usage: printf [-v var] format [arguments]
> >
> > Instead of relying printf expansion, fall back to the more trivial
> > printf n times which works with any char.
> >
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> > ---
> > 5-make-release-commit | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/5-make-release-commit b/5-make-release-commit
> > index 374154f..00acf92 100755
> > --- a/5-make-release-commit
> > +++ b/5-make-release-commit
> > @@ -29,7 +29,7 @@ function rstheader()
> >
> > echo
> > echo "${msg}"
> > - printf "${rchar}%.0s" $(seq 1 ${#msg})
> > + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done
> > # break after line plus one empty line
> > echo
> > echo
> >
>
> Acked-by: Kevin Traynor <ktraynor at redhat.com>
Thank you both for the review, pushed to the stable-scripts git now.
--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd
More information about the stable
mailing list