[PATCH] vdpa/mlx5: fix leak on event thread creation

Maxime Coquelin maxime.coquelin at redhat.com
Fri Jul 1 10:33:20 CEST 2022



On 7/1/22 10:30, David Marchand wrote:
> On Mon, Jun 20, 2022 at 3:11 PM David Marchand
> <david.marchand at redhat.com> wrote:
>>
>> As stated in the manual, pthread_attr_init return value should be
>> checked.
>> Besides, a pthread_attr_t should be destroyed once unused.
>>
>> In practice, we may have no leak (from what I read in glibc current code),
>> but this may change in the future.
>> Stick to a correct use of the API.
>>
>> Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling thread")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand at redhat.com>
> 
> Review, please?
> 
> 

I reviewed the patch but was waiting for Nvidia to test it.


Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Nvidia, could it be done ASAP so that it goes to -rc3?

Thanks,
Maxime



More information about the stable mailing list