[EXT] patch 'examples/fips_validation: handle empty payload' has been queued to stable release 21.11.2

Gowrishankar Muthukrishnan gmuthukrishn at marvell.com
Thu Jul 7 09:22:26 CEST 2022


Hi Luca,
Please drop this fix, as I am reverting it for a better alternative. Shortly I ll post a patch.

Thanks,
Gowrishankar

> -----Original Message-----
> From: luca.boccassi at gmail.com <luca.boccassi at gmail.com>
> Sent: Thursday, July 7, 2022 2:05 AM
> To: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> Cc: Fan Zhang <roy.fan.zhang at intel.com>; dpdk stable <stable at dpdk.org>
> Subject: [EXT] patch 'examples/fips_validation: handle empty payload' has
> been queued to stable release 21.11.2
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi,
> 
> FYI, your patch has been queued to stable release 21.11.2
> 
> Note it hasn't been pushed to
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__dpdk.org_browse_dpdk-
> 2Dstable&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=O2PVDcsc2jMEc_mE6Xe
> sj52a6pfU3j2Tnm4zolBaKA89l0u7LxsGH-
> 96953ZrpZK&s=4Gnb_mWIkB5BPsKGuZ45SRvpvN3EjpdmkVaD3cbDiFc&e=
> yet.
> It will be pushed if I get no objections before 07/08/22. So please shout if
> anyone has objections.
> 
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for
> rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
> 
> Queued patches are on a temporary branch at:
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_kevintraynor_dpdk-
> 2Dstable&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=O2PVDcsc2jMEc_mE6Xe
> sj52a6pfU3j2Tnm4zolBaKA89l0u7LxsGH-
> 96953ZrpZK&s=LnrfYb9zJZbja3SE0piaX3QRtUu9Ei_dUAtR5A3lKok&e=
> 
> This queued commit can be viewed at:
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_kevintraynor_dpdk-
> 2Dstable_commit_f2a62f854ed397d37710255a3e8d137a3e514f67&d=DwIDAg
> &c=nKjWec2b6R0mOyPaz7xtfQ&r=EAtr-
> g7yUFhtOio8r2Rtm13Aqe4WVp_S_gHpcu6KFVo&m=O2PVDcsc2jMEc_mE6Xe
> sj52a6pfU3j2Tnm4zolBaKA89l0u7LxsGH-
> 96953ZrpZK&s=HzrKlKMVYNlWanZ1zbvBgERFNcztMaGWajZensHeAz4&e=
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> From f2a62f854ed397d37710255a3e8d137a3e514f67 Mon Sep 17 00:00:00
> 2001
> From: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> Date: Tue, 28 Jun 2022 18:41:09 +0530
> Subject: [PATCH] examples/fips_validation: handle empty payload
> 
> [ upstream commit 0fab1428332bdfb213b51e068625d38419488646 ]
> 
> Allocate at least onebyte to handle empty payload in a test vector when
> defined.
> 
> Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application")
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn at marvell.com>
> Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
> ---
>  examples/fips_validation/fips_validation.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/fips_validation/fips_validation.c
> b/examples/fips_validation/fips_validation.c
> index 52a7bf952d..511c176a2a 100644
> --- a/examples/fips_validation/fips_validation.c
> +++ b/examples/fips_validation/fips_validation.c
> @@ -522,7 +522,7 @@ parse_uint8_hex_str(const char *key, char *src,
> struct fips_val *val)
>  		val->val = NULL;
>  	}
> 
> -	val->val = rte_zmalloc(NULL, len, 0);
> +	val->val = rte_zmalloc(NULL, len + 1, 0);
>  	if (!val->val)
>  		return -ENOMEM;
> 
> --
> 2.34.1
> 
> ---
>   Diff of the applied patch vs upstream commit (please double-check if non-
> empty:
> ---
> --- -	2022-07-06 21:07:53.714139949 +0100
> +++ 0004-examples-fips_validation-handle-empty-payload.patch	2022-
> 07-06 21:07:53.523518323 +0100
> @@ -1 +1 @@
> -From 0fab1428332bdfb213b51e068625d38419488646 Mon Sep 17 00:00:00
> 2001
> +From f2a62f854ed397d37710255a3e8d137a3e514f67 Mon Sep 17 00:00:00
> 2001
> @@ -5,0 +6,2 @@
> +[ upstream commit 0fab1428332bdfb213b51e068625d38419488646 ]
> +
> @@ -10 +11,0 @@
> -Cc: stable at dpdk.org
> @@ -19 +20 @@
> -index 94e31abf83..324abccb14 100644
> +index 52a7bf952d..511c176a2a 100644
> @@ -22 +23 @@
> -@@ -630,7 +630,7 @@ parse_uint8_hex_str(const char *key, char *src,
> struct fips_val *val)
> +@@ -522,7 +522,7 @@ parse_uint8_hex_str(const char *key, char *src,
> +struct fips_val *val)


More information about the stable mailing list