patch 'app/testpmd: revert MAC update in checksum forwarding' has been queued to stable release 20.11.6

Xueming Li xuemingl at nvidia.com
Wed Jul 20 10:20:50 CEST 2022


Hi,

FYI, your patch has been queued to stable release 20.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/22/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/bbba8ef0cd92ddf853dcd6035e64b62df464bbb8

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From bbba8ef0cd92ddf853dcd6035e64b62df464bbb8 Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Wed, 8 Jun 2022 14:49:41 +0200
Subject: [PATCH] app/testpmd: revert MAC update in checksum forwarding
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ]

This patch reverts
commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"),
as the checksum forwarding is expected to only perform
checksum and not also overwrites the source and destination MAC addresses.

Doing so, we can test checksum offloading with real traffic
without breaking broadcast packets.

Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Acked-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Aman Singh <aman.deep.singh at intel.com>
---
 app/test-pmd/csumonly.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 8adac07cb6..ffec25f308 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -888,10 +888,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
 		 * and inner headers */
 
 		eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
-		rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
-				&eth_hdr->d_addr);
-		rte_ether_addr_copy(&ports[fs->tx_port].eth_addr,
-				&eth_hdr->s_addr);
 		parse_ethernet(eth_hdr, &info);
 		l3_hdr = (char *)eth_hdr + info.l2_len;
 
-- 
2.35.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-07-20 15:00:59.756426957 +0800
+++ 0021-app-testpmd-revert-MAC-update-in-checksum-forwarding.patch	2022-07-20 15:00:58.707667169 +0800
@@ -1 +1 @@
-From 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 Mon Sep 17 00:00:00 2001
+From bbba8ef0cd92ddf853dcd6035e64b62df464bbb8 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ]
@@ -15 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +27 @@
-index 7df201e047..1a3fd9ce8a 100644
+index 8adac07cb6..ffec25f308 100644
@@ -28 +30 @@
-@@ -916,10 +916,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
+@@ -888,10 +888,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
@@ -33 +35 @@
--				&eth_hdr->dst_addr);
+-				&eth_hdr->d_addr);
@@ -35 +37 @@
--				&eth_hdr->src_addr);
+-				&eth_hdr->s_addr);


More information about the stable mailing list