[dpdk-dev] [PATCH 2/2] net/tap: fix use after free on error path
Yunjian Wang
wangyunjian at huawei.com
Tue Jun 7 08:50:57 CEST 2022
The error path was calling rte_eth_dev_release_port() function,
which frees eth_dev->data->dev_private, and then tries to free
pmd->intr_handle, which causes the use after free issue.
The free can be moved to before the release function is called.
Fixes: d61138d4f0e ("drivers: remove direct access to interrupt handle")
Cc: stable at dpdk.org
Signed-off-by: Xiangjun Meng <mengxiangjun4 at huawei.com>
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 5495818be6..9e1032fe72 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2179,8 +2179,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,
close(pmd->ioctl_sock);
/* mac_addrs must not be freed alone because part of dev_private */
dev->data->mac_addrs = NULL;
- rte_eth_dev_release_port(dev);
rte_intr_instance_free(pmd->intr_handle);
+ rte_eth_dev_release_port(dev);
error_exit_nodev:
TAP_LOG(ERR, "%s Unable to initialize %s",
--
2.27.0
More information about the stable
mailing list