patch 'ethdev: fix port state when stop' has been queued to stable release 20.11.6

Xueming Li xuemingl at nvidia.com
Tue Jun 21 10:02:29 CEST 2022


Hi,

FYI, your patch has been queued to stable release 20.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/23/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/d096c590deef6b8352eec0ca5c67fb9cb81b39a7

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From d096c590deef6b8352eec0ca5c67fb9cb81b39a7 Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Tue, 3 May 2022 18:02:17 +0800
Subject: [PATCH] ethdev: fix port state when stop
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ]

Currently, 'dev_started' is always set to be 0 when dev stop, whether
it succeeded or failed. This is unreasonable and this patch fixed it.

Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Acked-by: Thomas Monjalon <thomas at monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit at xilinx.com>
---
 lib/librte_ethdev/rte_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 259498342d..ac88c4484e 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1785,8 +1785,9 @@ rte_eth_dev_stop(uint16_t port_id)
 		return 0;
 	}
 
-	dev->data->dev_started = 0;
 	ret = (*dev->dev_ops->dev_stop)(dev);
+	if (ret == 0)
+		dev->data->dev_started = 0;
 	rte_ethdev_trace_stop(port_id, ret);
 
 	return ret;
-- 
2.35.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-21 15:37:53.006656095 +0800
+++ 0083-ethdev-fix-port-state-when-stop.patch	2022-06-21 15:37:49.174451737 +0800
@@ -1 +1 @@
-From 74b74269978c2790bc49238029e00b7c6e81c450 Mon Sep 17 00:00:00 2001
+From d096c590deef6b8352eec0ca5c67fb9cb81b39a7 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +18 @@
- lib/ethdev/rte_ethdev.c | 3 ++-
+ lib/librte_ethdev/rte_ethdev.c | 3 ++-
@@ -19,7 +21,7 @@
-diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
-index a175867651..fe64f8d39d 100644
---- a/lib/ethdev/rte_ethdev.c
-+++ b/lib/ethdev/rte_ethdev.c
-@@ -1533,8 +1533,9 @@ rte_eth_dev_stop(uint16_t port_id)
- 	/* point fast-path functions to dummy ones */
- 	eth_dev_fp_ops_reset(rte_eth_fp_ops + port_id);
+diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
+index 259498342d..ac88c4484e 100644
+--- a/lib/librte_ethdev/rte_ethdev.c
++++ b/lib/librte_ethdev/rte_ethdev.c
+@@ -1785,8 +1785,9 @@ rte_eth_dev_stop(uint16_t port_id)
+ 		return 0;
+ 	}


More information about the stable mailing list