[PATCH] examples/distributor: fix syntax on single core rx and distributor

Omer Yamac omer.yamac at ceng.metu.edu.tr
Tue Jun 21 13:18:02 CEST 2022


On 21.06.2022 13:26, Ferruh Yigit wrote:
> On 6/21/2022 9:44 AM, Hunt, David wrote:
>> 
>> Hi Ferruh,
>> 
>> On 20/06/2022 18:10, Ferruh Yigit wrote:
>>> On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote:
>>>> This patch fixes the syntax error when using the single-core
>>>> for both rx and distributor functions.
>>>> 
>>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>>> Cc: stable at dpdk.org
>>>> 
>>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac at ceng.metu.edu.tr>
>>> 
>>> Acked-by: Ferruh Yigit <ferruh.yigit at xilinx.com>
>>> 
>>> 
>>> Can we convert compile time macro to dynamic configuration to prevent
>>> build errors like this?
>> 
>> 
>> +1 for the dynamic config. Maybe a "-c" on the command line for 
>> "combine
>> rx and dist threads"?
>> 
> 
> Hi Dave,
> 
> '-c' sounds good,
> 
> Can you, or someone you delegate, address this, or should we create a
> bugzilla to record?
> 
> Or Omer if you are interested in doing this change, please let us know.

Hi Ferruh,
I can do it, if you can review it. Because I am trying to getting 
familiar of your coding style.

> 
>> 
>> Tested-by: David Hunt <david.hunt at intel.com>
>> 
>> 


More information about the stable mailing list