[PATCH] ice/base: fix gcc 12 warning stringop-overflow

David Marchand david.marchand at redhat.com
Thu Jun 23 09:42:56 CEST 2022


On Mon, Jun 20, 2022 at 7:06 AM Wu, WenxuanX <wenxuanx.wu at intel.com> wrote:
> > > > diff --git a/drivers/net/ice/base/ice_protocol_type.h
> > > > b/drivers/net/ice/base/ice_protocol_type.h
> > > > index 0e6e5990be..cfe3b62630 100644
> > > > --- a/drivers/net/ice/base/ice_protocol_type.h
> > > > +++ b/drivers/net/ice/base/ice_protocol_type.h
> > > > @@ -421,7 +421,7 @@ struct ice_recp_grp_entry {  #define
> > > > ICE_INVAL_CHAIN_IND 0xFF
> > > >   u16 rid;
> > > >   u8 chain_idx;
> > > > - u16 fv_idx[ICE_NUM_WORDS_RECIPE];
> > > > + u8 fv_idx[ICE_NUM_WORDS_RECIPE];
> > >
> > > If you change the data type from u16 to u8 for the FV index, you'd
> > > better also change the type of all the symbols to store the same
> > > thing.  e.g. the parameter "fv_idx" of ice_find_prot_off.
> > > So, what's exactly the issue that GCC 12 reported? can we fix it from
> > > the other side without changing a type in the base code?
>         change from u8 lkup_indx[5] to u16 lkup_indx[5] can also resolve this issue.

Any update?
Thanks.

-- 
David Marchand



More information about the stable mailing list