patch 'sched: remove unnecessary floating point' has been queued to stable release 21.11.2

Kevin Traynor ktraynor at redhat.com
Fri Jun 24 17:01:11 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/bba01c7ab88dfac1a732b3fb12cf81921bec9da2

Thanks.

Kevin

---
>From bba01c7ab88dfac1a732b3fb12cf81921bec9da2 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 26 May 2022 13:26:52 -0700
Subject: [PATCH] sched: remove unnecessary floating point

[ upstream commit bb421e98c0c0f56f1adc68722a54d6d24abf137d ]

The qdelay variable is derived from and compared to 64 bit
value so it doesn't have to be floating point.

Fixes: 44c730b0e379 ("sched: add PIE based congestion management")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Jasvinder Singh <jasvinder.singh at intel.com>
---
 lib/sched/rte_pie.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h
index 02a987f54a..3e2c1ef467 100644
--- a/lib/sched/rte_pie.h
+++ b/lib/sched/rte_pie.h
@@ -219,5 +219,5 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg,
 {
 	uint64_t rand_value;
-	double qdelay = pie_cfg->qdelay_ref * 0.5;
+	uint64_t qdelay = pie_cfg->qdelay_ref / 2;
 
 	/* PIE is active but the queue is not congested: return 0 */
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-24 15:51:08.993883078 +0100
+++ 0003-sched-remove-unnecessary-floating-point.patch	2022-06-24 15:51:08.811983920 +0100
@@ -1 +1 @@
-From bb421e98c0c0f56f1adc68722a54d6d24abf137d Mon Sep 17 00:00:00 2001
+From bba01c7ab88dfac1a732b3fb12cf81921bec9da2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bb421e98c0c0f56f1adc68722a54d6d24abf137d ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list