patch 'net/hns3: fix link status capability query from VF' has been queued to stable release 21.11.2

Kevin Traynor ktraynor at redhat.com
Tue Jun 28 17:19:25 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/30/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a650bf5cfed955ba68195a875376867f450ae3b3

Thanks.

Kevin

---
>From a650bf5cfed955ba68195a875376867f450ae3b3 Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Sat, 11 Jun 2022 15:42:26 +0800
Subject: [PATCH] net/hns3: fix link status capability query from VF

[ upstream commit a8e1bd096fa9a96e3f50c14e92017b7416536038 ]

Currently, the VF LSC capability is obtained from PF driver in
the interrupt mailbox interrupt thread, it is asynchronous.
The VF driver waits for 500ms to get this capability in probe
process.

The primary process will receive a message and do probe in the
interrupt thread context when attach a device in the secondary
process. At this case, VF driver never obtains this capability
from PF.

The root cause is that 'vf->pf_push_lsc_cap' is not updated by
the handling mailbox thread until finishing probe. The reason
this update wouldn't be done is that the handling mailbox interrupt
thread and the probe alarm thread are both in epool thread, and
the probe alarm thread is before the mailbox interrupt thread.

Fixes: 9bc2289fe5ea ("net/hns3: refactor VF LSC event report")

Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
---
 drivers/net/hns3/hns3_ethdev_vf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index 7a843fd7d5..0af4dcb324 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -780,4 +780,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
 	while (remain_ms > 0) {
 		rte_delay_ms(HNS3_POLL_RESPONE_MS);
+		/*
+		 * The probe process may perform in interrupt thread context.
+		 * For example, users attach a device in the secondary process.
+		 * At the moment, the handling mailbox task will be blocked. So
+		 * driver has to actively handle the HNS3_MBX_LINK_STAT_CHANGE
+		 * mailbox from PF driver to get this capability.
+		 */
+		hns3_dev_handle_mbx_msg(hw);
 		if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=
 			HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-28 16:18:04.338721900 +0100
+++ 0013-net-hns3-fix-link-status-capability-query-from-VF.patch	2022-06-28 16:18:04.022387176 +0100
@@ -1 +1 @@
-From a8e1bd096fa9a96e3f50c14e92017b7416536038 Mon Sep 17 00:00:00 2001
+From a650bf5cfed955ba68195a875376867f450ae3b3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a8e1bd096fa9a96e3f50c14e92017b7416536038 ]
+
@@ -23 +24,0 @@
-Cc: stable at dpdk.org
@@ -32 +33 @@
-index bebfaa6417..3abd4aafcb 100644
+index 7a843fd7d5..0af4dcb324 100644
@@ -35 +36 @@
-@@ -778,4 +778,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
+@@ -780,4 +780,12 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)



More information about the stable mailing list