[PATCH v1] net/vhost: clear data of packet mbuf after sending pkts
Yuying Zhang
yuying.zhang at intel.com
Tue Mar 1 08:28:02 CET 2022
The PMD frees a packet mbuf back into its original mempool
after sending a packet. However, old data is not cleaned up
which causes error in payload of new packets. This patch clear
data of packet mbuf before freeing mbuf.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable at dpdk.org
Signed-off-by: Yuying Zhang <yuying.zhang at intel.com>
---
drivers/net/vhost/rte_eth_vhost.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 070f0e6dfd..92ed07a334 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -417,10 +417,11 @@ static uint16_t
eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
{
struct vhost_queue *r = q;
- uint16_t i, nb_tx = 0;
+ uint16_t i, j, nb_tx = 0;
uint16_t nb_send = 0;
uint64_t nb_bytes = 0;
uint64_t nb_missed = 0;
+ void *data = NULL;
if (unlikely(rte_atomic32_read(&r->allow_queuing) == 0))
return 0;
@@ -483,8 +484,13 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
for (i = nb_tx; i < nb_bufs; i++)
vhost_count_xcast_packets(r, bufs[i]);
- for (i = 0; likely(i < nb_tx); i++)
+ for (i = 0; likely(i < nb_tx); i++) {
+ for (j = 0; j < bufs[i]->nb_segs; j++) {
+ data = rte_pktmbuf_mtod(bufs[i], void *);
+ memset(data, 0, bufs[i]->data_len);
+ }
rte_pktmbuf_free(bufs[i]);
+ }
out:
rte_atomic32_set(&r->while_queuing, 0);
--
2.25.1
More information about the stable
mailing list