patch 'test/dma: fix missing checks for device capacity' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Tue Mar 1 11:41:31 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/06/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/ebc0188ccb8bca848a75ec0e1a268829ca92319c

Thanks.

Kevin

---
>From ebc0188ccb8bca848a75ec0e1a268829ca92319c Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Wed, 16 Feb 2022 16:06:07 +0000
Subject: [PATCH] test/dma: fix missing checks for device capacity

[ upstream commit 727e6b784087306801d487590e03d00b4e6e2485 ]

For some DMA HW devices, e.g. those using the idxd driver, the maximum
burst size is configurable, which can lead to test failures if the value
is set too small. Add explicit check for this to give reasonable error
messages for devices which need their config adjusted.

Fixes: 1b86a66a30c2 ("test/dma: add more comprehensive copy tests")
Fixes: 8fa5d2683940 ("test/dma: add burst capacity test")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Reviewed-by: Conor Walsh <conor.walsh at intel.com>
Reviewed-by: Kevin Laatz <kevin.laatz at intel.com>
---
 app/test/test_dmadev.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index b206db27ae..e40c29c23b 100644
--- a/app/test/test_dmadev.c
+++ b/app/test/test_dmadev.c
@@ -775,4 +775,7 @@ test_dmadev_instance(int16_t dev_id)
 		ERR_RETURN("Error with rte_dma_stats_get()\n");
 
+	if (rte_dma_burst_capacity(dev_id, vchan) < 32)
+		ERR_RETURN("Error: Device does not have sufficient burst capacity to run tests");
+
 	if (stats.completed != 0 || stats.submitted != 0 || stats.errors != 0)
 		ERR_RETURN("Error device stats are not all zero: completed = %"PRIu64", "
@@ -796,5 +799,8 @@ test_dmadev_instance(int16_t dev_id)
 
 	/* run some burst capacity tests */
-	if (runtest("burst capacity", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0)
+	if (rte_dma_burst_capacity(dev_id, vchan) < 64)
+		printf("DMA Dev %u: insufficient burst capacity (64 required), skipping tests\n",
+				dev_id);
+	else if (runtest("burst capacity", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0)
 		goto err;
 
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-01 10:41:01.818237132 +0000
+++ 0015-test-dma-fix-missing-checks-for-device-capacity.patch	2022-03-01 10:41:01.251244087 +0000
@@ -1 +1 @@
-From 727e6b784087306801d487590e03d00b4e6e2485 Mon Sep 17 00:00:00 2001
+From ebc0188ccb8bca848a75ec0e1a268829ca92319c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 727e6b784087306801d487590e03d00b4e6e2485 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index db5aff701c..2b097e0f47 100644
+index b206db27ae..e40c29c23b 100644
@@ -26 +27 @@
-@@ -776,4 +776,7 @@ test_dmadev_instance(int16_t dev_id)
+@@ -775,4 +775,7 @@ test_dmadev_instance(int16_t dev_id)
@@ -34 +35 @@
-@@ -797,5 +800,8 @@ test_dmadev_instance(int16_t dev_id)
+@@ -796,5 +799,8 @@ test_dmadev_instance(int16_t dev_id)



More information about the stable mailing list