patch 'crypto/ipsec_mb: remove useless check' has been queued to stable release 21.11.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/06/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c8bcbe8b682c1a894dc2e632a584d215e4950b7b

Thanks.

Kevin

---
>From c8bcbe8b682c1a894dc2e632a584d215e4950b7b Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Tue, 15 Feb 2022 11:07:58 +0000
Subject: [PATCH] crypto/ipsec_mb: remove useless check

[ upstream commit f819a1629b1ccc9ed74e17374e26507a490058ac ]

The qp is never NULL when it reaches the qp_setup_cleanup error handling
code. This is due to checks earlier in the function that return an error
if qp is NULL.

Coverity issue: 375013
Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer dereference")

Signed-off-by: Ciara Power <ciara.power at intel.com>
---
 drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index 1ebd23e8f0..58ea4ee476 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -286,6 +286,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
 
 qp_setup_cleanup:
-	if (qp == NULL)
-		return ret;
 #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
 	if (qp->mb_mgr)
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-01 10:41:02.051013528 +0000
+++ 0025-crypto-ipsec_mb-remove-useless-check.patch	2022-03-01 10:41:01.273244091 +0000
@@ -1 +1 @@
-From f819a1629b1ccc9ed74e17374e26507a490058ac Mon Sep 17 00:00:00 2001
+From c8bcbe8b682c1a894dc2e632a584d215e4950b7b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f819a1629b1ccc9ed74e17374e26507a490058ac ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 1cf37e9836..7e8396b4a3 100644
+index 1ebd23e8f0..58ea4ee476 100644
@@ -23 +24 @@
-@@ -285,6 +285,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
+@@ -286,6 +286,4 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,