patch 'devargs: fix crash with uninitialized parsing' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Tue Mar 1 11:42:58 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/06/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956

Thanks.

Kevin

---
>From d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956 Mon Sep 17 00:00:00 2001
From: Madhuker Mythri <madhuker.mythri at oracle.com>
Date: Mon, 14 Feb 2022 22:38:11 +0530
Subject: [PATCH] devargs: fix crash with uninitialized parsing

[ upstream commit 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 ]

The function rte_devargs_parse() previously was safe to call with
non-initialized devargs structure as parameter.

When adding the support for the global device syntax,
this assumption was broken.
Restore it by forcing memset as part of the call itself.

Bugzilla ID: 933
Fixes: b344eb5d941a ("devargs: parse global device syntax")

Signed-off-by: Madhuker Mythri <madhuker.mythri at oracle.com>
Signed-off-by: Gaetan Rivet <grive at u256.net>
---
 lib/eal/common/eal_common_devargs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c
index 8c7650cf6c..184fe676aa 100644
--- a/lib/eal/common/eal_common_devargs.c
+++ b/lib/eal/common/eal_common_devargs.c
@@ -192,4 +192,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
 	if (da == NULL)
 		return -EINVAL;
+	memset(da, 0, sizeof(*da));
 
 	/* First parse according global device syntax. */
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-01 10:41:04.137334324 +0000
+++ 0102-devargs-fix-crash-with-uninitialized-parsing.patch	2022-03-01 10:41:01.485244135 +0000
@@ -1 +1 @@
-From 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 Mon Sep 17 00:00:00 2001
+From d3e4a2c2e6c897b944c459c8b09e9f4ceab4e956 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 356a2aa054a9e803782ee8380a7ab1a53aecd1e3 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 8da3ba3879..d5833af373 100644
+index 8c7650cf6c..184fe676aa 100644
@@ -27 +28 @@
-@@ -190,4 +190,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
+@@ -192,4 +192,5 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)



More information about the stable mailing list