[EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure

[Vamsi Krishna Attunuru]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Thursday, March 3, 2022 10:52 PM
> To: Vamsi Krishna Attunuru <vattunuru at marvell.com>; dev at dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram at marvell.com>; yux.jiang at intel.com;
> stable at dpdk.org; Wei Ling <weix.ling at intel.com>; Srikanth Yalavarthi
> <syalavarthi at marvell.com>
> Subject: [EXT] Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 3/2/2022 1:46 PM, Vamsi Attunuru wrote:
> > Use dynamically allocated memory for storing soft expiry ring base
> > addresses which fixes the static assertion failure, as the size of
> > dynamic allocation depends on RTE_MAX_ETHPORTS which varies based on
> > the build config.
> >
> 
> Hi Vamsi,
> 
> "fix static assertion failure" is not enough descriptive.
> assertions already added to verify assumptions, and in this case it seems it
> failed, but what was actually wrong?
> 
> Is it that allocated memory size for ring wrong? (this is what I got from
> commit log but I am not sure)
> 
> Can you please describe what actually was wrong and fixed now?
> 
Hi Ferruh,

Earlier sa_soft_exp_ring struct member was an array of pointers and it's size is linked to num RTE_MAX_ETHPORTS, 
and the whole struct size is confined and protected by size assertion.  It resulted in build failure with -Dmax_ethports=1024
option and assertion caught that failure. V2 fixes the issues by allocating the required memory dynamically instead
 of using array of pointers.

> > Bugzilla ID: 940
> > Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry
> > notification") Cc:stable at dpdk.org
> >
> > Reported-by: Wei Ling<weix.ling at intel.com>
> > Reported-by: Yu Jiang<yux.jiang at intel.com>
> > Signed-off-by: Vamsi Attunuru<vattunuru at marvell.com>
> > Signed-off-by: Srikanth Yalavarthi<syalavarthi at marvell.com>
> > ---
> > V2: Add bugzilla & reportee details, remove unused changes.
> > ---