[PATCH] examples/distributor: one Tx queue is enough

Honnappa Nagarahalli Honnappa.Nagarahalli at arm.com
Tue Mar 8 04:26:40 CET 2022


The ABI test failure is not related to this patch.
Thanks,
Honnappa

> -----Original Message-----
> From: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> Sent: Monday, March 7, 2022 4:40 PM
> To: dev at dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli at arm.com>; lijuan.tu at intel.com;
> juraj.linkes at pantheon.tech; ohilyard at iol.unh.edu;
> david.marchand at redhat.com; thomas at monjalon.net; david.hunt at intel.com
> Cc: Ruifeng Wang <Ruifeng.Wang at arm.com>; nd <nd at arm.com>;
> bruce.richardson at intel.com; reshma.pattan at intel.com; stable at dpdk.org
> Subject: [PATCH] examples/distributor: one Tx queue is enough
> 
> Distributor application creates one Tx queue per core. However the transmit is
> done only from a single core. Hence creating one Tx queue is enough.
> 
> Fixes: 07db4a975094 ("examples/distributor: new sample app")
> Cc: bruce.richardson at intel.com
> Cc: reshma.pattan at intel.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> ---
> DTS test cases make this change to DPDK. However, I find that, one queue is
> enough. Hence we could make this change in DPDK.
> 
>  examples/distributor/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/distributor/main.c b/examples/distributor/main.c index
> c681e237ea..02bf91f555 100644
> --- a/examples/distributor/main.c
> +++ b/examples/distributor/main.c
> @@ -108,7 +108,7 @@ static inline int
>  port_init(uint16_t port, struct rte_mempool *mbuf_pool)  {
>  	struct rte_eth_conf port_conf = port_conf_default;
> -	const uint16_t rxRings = 1, txRings = rte_lcore_count() - 1;
> +	const uint16_t rxRings = 1, txRings = 1;
>  	int retval;
>  	uint16_t q;
>  	uint16_t nb_rxd = RX_RING_SIZE;
> --
> 2.25.1



More information about the stable mailing list