patch 'net/txgbe: fix queue statistics mapping' has been queued to stable release 20.11.5

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Mar 9 17:30:29 CET 2022


Hi,

FYI, your patch has been queued to stable release 20.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/4e76a13521aa9afb7576712309f052ee418f6471

Thanks.

Luca Boccassi

---
>From 4e76a13521aa9afb7576712309f052ee418f6471 Mon Sep 17 00:00:00 2001
From: Weiguo Li <liwg06 at foxmail.com>
Date: Tue, 1 Mar 2022 14:08:30 +0800
Subject: [PATCH] net/txgbe: fix queue statistics mapping

[ upstream commit f69467177fa34afaeeeae81ad83142121ee1bc98 ]

Since boolean value is in 0 and 1, it's strange to combines a boolean
value with a bit operator.

Thus it's highly possible a typo error with "if (A & !B)", and more
probably to use "if (A & ~B)" instead.

Fixes: c1d4e9d37abd ("net/txgbe: add queue stats mapping")

Signed-off-by: Weiguo Li <liwg06 at foxmail.com>
Acked-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 4a5d6aad26..1a2c9ff976 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -366,7 +366,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
 	if (hw->mac.type != txgbe_mac_raptor)
 		return -ENOSYS;
 
-	if (stat_idx & !QMAP_FIELD_RESERVED_BITS_MASK)
+	if (stat_idx & ~QMAP_FIELD_RESERVED_BITS_MASK)
 		return -EIO;
 
 	PMD_INIT_LOG(DEBUG, "Setting port %d, %s queue_id %d to stat index %d",
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-09 16:30:09.023214853 +0000
+++ 0013-net-txgbe-fix-queue-statistics-mapping.patch	2022-03-09 16:30:08.523024617 +0000
@@ -1 +1 @@
-From f69467177fa34afaeeeae81ad83142121ee1bc98 Mon Sep 17 00:00:00 2001
+From 4e76a13521aa9afb7576712309f052ee418f6471 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f69467177fa34afaeeeae81ad83142121ee1bc98 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 19d4444748..f0994f028d 100644
+index 4a5d6aad26..1a2c9ff976 100644
@@ -25 +26 @@
-@@ -376,7 +376,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
+@@ -366,7 +366,7 @@ txgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,


More information about the stable mailing list