patch 'net/mlx5: fix configuration without Rx queue' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Thu Mar 10 13:11:20 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/14/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a17cea76b791059e9489a7892349fdce89c48bd8

Thanks.

Kevin

---
>From a17cea76b791059e9489a7892349fdce89c48bd8 Mon Sep 17 00:00:00 2001
From: Bing Zhao <bingz at nvidia.com>
Date: Thu, 3 Mar 2022 17:26:58 +0200
Subject: [PATCH] net/mlx5: fix configuration without Rx queue

[ upstream commit 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 ]

None Rx queue configured in a DPDK application should be supported.
In this mode, the NIC can be used to generate packets without
receiving any ingress traffic.

In the current implementation, once there is no Rx queue specified,
the array to store the queues' pointers is NULL after allocation.
Then the checking of the array allocation prevents the application
from starting up.

By adding another condition checking of the Rx queue number, the
application with none Rx queue can start up successfully.

Fixes: 4cda06c3c35e ("net/mlx5: split Rx queue into shareable and private")

Signed-off-by: Bing Zhao <bingz at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 drivers/net/mlx5/mlx5_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index dc647d5580..9c44471c42 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -110,5 +110,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 				       sizeof(void *) * rxqs_n, 0,
 				       SOCKET_ID_ANY);
-	if (priv->rxq_privs == NULL) {
+	if (rxqs_n && priv->rxq_privs == NULL) {
 		DRV_LOG(ERR, "port %u cannot allocate rxq private data",
 			dev->data->port_id);
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-10 12:05:31.861525946 +0000
+++ 0021-net-mlx5-fix-configuration-without-Rx-queue.patch	2022-03-10 12:05:31.316630896 +0000
@@ -1 +1 @@
-From 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 Mon Sep 17 00:00:00 2001
+From a17cea76b791059e9489a7892349fdce89c48bd8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3ef18940ef13fe8cb307aba0dba2bc316fb873a2 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -28 +29 @@
-index de0ba2b1ff..05c919ed39 100644
+index dc647d5580..9c44471c42 100644
@@ -31 +32 @@
-@@ -112,5 +112,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
+@@ -110,5 +110,5 @@ mlx5_dev_configure(struct rte_eth_dev *dev)



More information about the stable mailing list