patch 'crypto/ipsec_mb: fix GCM requested digest length' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Wed Mar 16 16:15:11 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/21/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/75c570058bc84363756d2a7a36e9650b73520381

Thanks.

Kevin

---
>From 75c570058bc84363756d2a7a36e9650b73520381 Mon Sep 17 00:00:00 2001
From: Piotr Bronowski <piotrx.bronowski at intel.com>
Date: Wed, 9 Mar 2022 18:02:00 +0000
Subject: [PATCH] crypto/ipsec_mb: fix GCM requested digest length

[ upstream commit 2c6b3438d6caa096fca1b2f078f3ca18ce737ded ]

This patch removes coverity defect CID 375828:
Untrusted value as argument (TAINTED_SCALAR)

Coverity issue: 375828
Fixes: ceb863938708 ("crypto/aesni_gcm: support all truncated digest sizes")

Signed-off-by: Piotr Bronowski <piotrx.bronowski at intel.com>
Acked-by: Ciara Power <ciara.power at intel.com>
---
 drivers/crypto/ipsec_mb/pmd_aesni_gcm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c
index e5ad629fe5..2c033c6f28 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_gcm.c
@@ -97,5 +97,7 @@ aesni_gcm_session_configure(IMB_MGR *mb_mgr, void *session,
 		key_length = auth_xform->auth.key.length;
 		key = auth_xform->auth.key.data;
-		sess->req_digest_length = auth_xform->auth.digest_length;
+		sess->req_digest_length =
+		    RTE_MIN(auth_xform->auth.digest_length,
+				DIGEST_LENGTH_MAX);
 		break;
 	case IPSEC_MB_OP_AEAD_AUTHENTICATED_ENCRYPT:
@@ -117,5 +119,7 @@ aesni_gcm_session_configure(IMB_MGR *mb_mgr, void *session,
 		key = aead_xform->aead.key.data;
 		sess->aad_length = aead_xform->aead.aad_length;
-		sess->req_digest_length = aead_xform->aead.digest_length;
+		sess->req_digest_length =
+			RTE_MIN(aead_xform->aead.digest_length,
+				DIGEST_LENGTH_MAX);
 		break;
 	default:
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-03-16 15:14:12.391934910 +0000
+++ 0010-crypto-ipsec_mb-fix-GCM-requested-digest-length.patch	2022-03-16 15:14:12.108847604 +0000
@@ -1 +1 @@
-From 2c6b3438d6caa096fca1b2f078f3ca18ce737ded Mon Sep 17 00:00:00 2001
+From 75c570058bc84363756d2a7a36e9650b73520381 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2c6b3438d6caa096fca1b2f078f3ca18ce737ded ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list