[PATCH] test/bpf: skip test if libpcap is unavailable
Stephen Hemminger
stephen at networkplumber.org
Mon Mar 21 17:15:39 CET 2022
On Mon, 21 Mar 2022 06:13:27 -0700
Tyler Retzlaff <roretzla at linux.microsoft.com> wrote:
> test_bpf_convert is being conditionally registered depending on the
> presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a
> test to run.
>
> when the UT runs test_bpf_convert test-dpdk can't find the registration
> and assumes the DPDK_TEST environment variable hasn't been defined
> resulting in test-dpdk dropping to interactive mode and subsequently
> waiting for the remainder of the UT fast-test timeout period before
> reporting the test as having timed out.
>
> * unconditionally register test_bpf_convert
> * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the
> test is skipped similar to that done with the test_bpf test.
>
> Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF")
> Cc: stephen at networkplumber.org
> Cc: anatoly.burakov at intel.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
LGTM
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
More information about the stable
mailing list