[PATCH v7] eal: fix rte_memcpy strict aliasing/alignment bugs

David Marchand david.marchand at redhat.com
Thu May 19 18:41:56 CEST 2022


Hello Luc,

On Fri, May 13, 2022 at 9:16 PM Luc Pelletier <lucp.at.work at gmail.com> wrote:
> > > Actually, looking again at the history, it fixes:
> > > Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
> >
> > Nop, that's probably even older, could you double check?
> > I'll hold on pushing this fix.
>
> It seems you still haven't received a response. I'll take a stab at this.
>
> I think it fixes:
>
> Fixes: 76746eb13f08 ("eal/x86: fix strict aliasing rules")
>
> However, the ordering of the ifs (from 1 to 8, rather than 8 to 1)
> seems to date back to the first commit (af75078fece3). So, I'm not
> sure how you want to handle this.

My understanding was that the issue was there since "day 1".
I'll go with the latter then.

Backporting will be for all LTS branches in any case.

Thanks!


-- 
David Marchand



More information about the stable mailing list