patch 'eventdev/eth_rx: fix telemetry Rx stats reset' has been queued to stable release 21.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 25 18:28:44 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/30/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/09d859555f9d1555228ec3494443cba926f09643

Thanks.

Kevin

---
>From 09d859555f9d1555228ec3494443cba926f09643 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Thu, 24 Mar 2022 16:28:30 +0100
Subject: [PATCH] eventdev/eth_rx: fix telemetry Rx stats reset

[ upstream commit b450a990b07e008077377a6dfa45a562b3f9a496 ]

Caught by covscan:

1. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279:
logical_vs_bitwise: "~(*__ctype_b_loc()[(int)*params] & 2048 /*
(unsigned short)_ISdigit */)" is always 1/true regardless of the values
of its operand. This occurs as the logical second operand of "||".
2. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: remediation:
Did you intend to use "!" rather than "~"?

While isdigit return value should be compared as an int to 0,
prefer ! since all of this file uses this convention.

Fixes: 814d01709328 ("eventdev/eth_rx: support telemetry")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Jay Jayatheerthan <jay.jayatheerthan at intel.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index 4b46e9b6c6..2356e2a535 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3315,5 +3315,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused,
 	uint8_t rx_adapter_id;
 
-	if (params == NULL || strlen(params) == 0 || ~isdigit(*params))
+	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
 		return -1;
 
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-05-25 17:26:59.788081205 +0100
+++ 0052-eventdev-eth_rx-fix-telemetry-Rx-stats-reset.patch	2022-05-25 17:26:58.663828472 +0100
@@ -1 +1 @@
-From b450a990b07e008077377a6dfa45a562b3f9a496 Mon Sep 17 00:00:00 2001
+From 09d859555f9d1555228ec3494443cba926f09643 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b450a990b07e008077377a6dfa45a562b3f9a496 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -28 +29 @@
-index ff83ce8b67..bf8741d2ea 100644
+index 4b46e9b6c6..2356e2a535 100644
@@ -31 +32 @@
-@@ -3335,5 +3335,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused,
+@@ -3315,5 +3315,5 @@ handle_rxa_stats_reset(const char *cmd __rte_unused,



More information about the stable mailing list