[PATCH] event/dlb2: fix meson build

Jerin Jacob jerinjacobk at gmail.com
Fri Nov 4 12:00:20 CET 2022


On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit <ferruh.yigit at amd.com> wrote:
>
> On 11/3/2022 3:35 PM, Thomas Monjalon wrote:
> > 03/11/2022 16:22, Ferruh Yigit:
> >> "meson setup" fails when '-Werror' compiler flag is enabled [1].
> >> This is not a build error in the driver but a build error in meson
> >> during "meson setup" stage.
> >>
> >> This issue exists for a while but meson takes it as a warning and
> >> ignores it unless '-Werror' compiler flag is provided.
> > [...]
> >> Reproduced via `meson -Dc_args='-Werror' build`
> >
> > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh
> > or 'meson -Dwerror=true' as in .ci/linux-build.sh?
> >
>
> As I checked now, it seems there is a difference.
>
> Via "meson --werror" & "meson -Dwerror=true",
> '-Werror' flag is used to compile dpdk source code, but meson doesn't
> use the flag for its internal logic, so this seems more proper usage.
>
> Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage,
> '-Werror' flag is used both to compile dpdk code and meson internal
> logic, so that is why this usage cause build error.
>
>
> And independent from the above usage difference, event/dlb2 meson file
> is wrong and this fix is required.
> I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback
> and that is why mentioned error is not detected.

+ @abdullah.sevincer at intel.com

Waiting from Ack from Abdullah to merge


More information about the stable mailing list