patch 'trace: fix mode for new trace point' has been queued to stable release 20.11.7

luca.boccassi at gmail.com luca.boccassi at gmail.com
Sat Nov 5 18:11:00 CET 2022


Hi,

FYI, your patch has been queued to stable release 20.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/07/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/8ca66f87baadda422b67d9265a1cafa1ec7b4da4

Thanks.

Luca Boccassi

---
>From 8ca66f87baadda422b67d9265a1cafa1ec7b4da4 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Thu, 15 Sep 2022 10:13:23 +0200
Subject: [PATCH] trace: fix mode for new trace point

[ upstream commit 12b627bf772eb122ae195c297b08adcb92c8ac93 ]

If an application registers trace points later than rte_eal_init(),
changes in the trace point mode were not applied.

Fixes: 84c4fae4628f ("trace: implement operation APIs")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
Acked-by: Sunil Kumar Kori <skori at marvell.com>
---
 lib/librte_eal/common/eal_common_trace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c
index 24e27387b1..080278333d 100644
--- a/lib/librte_eal/common/eal_common_trace.c
+++ b/lib/librte_eal/common/eal_common_trace.c
@@ -513,6 +513,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,
 	/* Form the trace handle */
 	*handle = sz;
 	*handle |= trace.nb_trace_points << __RTE_TRACE_FIELD_ID_SHIFT;
+	trace_mode_set(handle, trace.mode);
 
 	trace.nb_trace_points++;
 	tp->handle = handle;
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-05 17:11:08.917725984 +0000
+++ 0001-trace-fix-mode-for-new-trace-point.patch	2022-11-05 17:11:08.550939979 +0000
@@ -1 +1 @@
-From 12b627bf772eb122ae195c297b08adcb92c8ac93 Mon Sep 17 00:00:00 2001
+From 8ca66f87baadda422b67d9265a1cafa1ec7b4da4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 12b627bf772eb122ae195c297b08adcb92c8ac93 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- lib/eal/common/eal_common_trace.c | 1 +
+ lib/librte_eal/common/eal_common_trace.c | 1 +
@@ -19,5 +20,5 @@
-diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c
-index f9b187d15f..d5dbc7d667 100644
---- a/lib/eal/common/eal_common_trace.c
-+++ b/lib/eal/common/eal_common_trace.c
-@@ -512,6 +512,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,
+diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c
+index 24e27387b1..080278333d 100644
+--- a/lib/librte_eal/common/eal_common_trace.c
++++ b/lib/librte_eal/common/eal_common_trace.c
+@@ -513,6 +513,7 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,


More information about the stable mailing list