[PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled

Raslan Darawsheh rasland at nvidia.com
Sun Nov 6 16:42:22 CET 2022


Hi,

> -----Original Message-----
> From: Spike Du <spiked at nvidia.com>
> Sent: Wednesday, November 2, 2022 1:44 PM
> To: Matan Azrad <matan at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; Ori Kam <orika at nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas at monjalon.net>; Shahaf Shuler
> <shahafs at nvidia.com>
> Cc: dev at dpdk.org; Raslan Darawsheh <rasland at nvidia.com>;
> stable at dpdk.org
> Subject: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled
> 
> When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler
> delays to reconfigure rx queue to re-arm this event. However at the same
> time, testpmd is destroying rx queues.
> It's never a valid use case for mlx5 avail_thresh. Before testpmd quit,
> user should disable avail_thresh configuration to not handle the events.
> This is documented in mlx5 driver guide.
> 
> To avoid the crash in such use case, check port status, if it is not
> RTE_PORT_STARTED, don't process the avail_thresh event.
> 
> Fixes: f41a5092e6ae ("app/testpmd: add host shaper command")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Spike Du <spiked at nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


More information about the stable mailing list