[PATCH v1] common/idpf: fix possible null dereference

Mingxia Liu mingxia.liu at intel.com
Wed Nov 9 06:17:07 CET 2022


From: mingxial <mingxia.liu at intel.com>

Coverity is reporting FORWARD_NULL issue when msg.ctx.indirect.payload
is NULL. Adding NULL check for this.

Coverity issue: 381689
Fixes: fb4ac04e9bfa ("common/idpf: introduce common library")
Cc: stable at dpdk.org

Signed-off-by: mingxial <mingxia.liu at intel.com>
---
 drivers/common/idpf/base/idpf_common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c
index bcc0c11ae8..3a9fdb1878 100644
--- a/drivers/common/idpf/base/idpf_common.c
+++ b/drivers/common/idpf/base/idpf_common.c
@@ -234,6 +234,8 @@ int idpf_clean_arq_element(struct idpf_hw *hw,
 	e->desc.ret_val = msg.status;
 	e->desc.datalen = msg.data_len;
 	if (msg.data_len > 0) {
+		if (!msg.ctx.indirect.payload)
+			return -EINVAL;
 		e->buf_len = msg.data_len;
 		msg_data_len = msg.data_len;
 		idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,
-- 
2.25.1



More information about the stable mailing list