patch 'common/iavf: avoid copy in async mode' has been queued to stable release 19.11.14

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Fri Nov 11 12:38:36 CET 2022


Hi,

FYI, your patch has been queued to stable release 19.11.14

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/18/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/033e89575192d23d38db7262021e4654379ec63c

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 033e89575192d23d38db7262021e4654379ec63c Mon Sep 17 00:00:00 2001
From: Steven Zou <steven.zou at intel.com>
Date: Mon, 5 Sep 2022 09:42:06 +0800
Subject: [PATCH] common/iavf: avoid copy in async mode

[ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ]

If cmd_details are defined or async flag is set,
don't copy the desc/buff back to temp.

Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")

Signed-off-by: Steven Zou <steven.zou at intel.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/iavf/base/iavf_adminq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c
index a41402e04e..43483c0ee1 100644
--- a/drivers/net/iavf/base/iavf_adminq.c
+++ b/drivers/net/iavf/base/iavf_adminq.c
@@ -807,7 +807,8 @@ enum iavf_status_code iavf_asq_send_command(struct iavf_hw *hw,
 	}
 
 	/* if ready, copy the desc back to temp */
-	if (iavf_asq_done(hw)) {
+	if (iavf_asq_done(hw) &&
+		!details->async && !details->postpone) {
 		iavf_memcpy(desc, desc_on_ring, sizeof(struct iavf_aq_desc),
 			    IAVF_DMA_TO_NONDMA);
 		if (buff != NULL)
-- 
2.38.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-11 12:35:05.465111763 +0100
+++ 0019-common-iavf-avoid-copy-in-async-mode.patch	2022-11-11 12:35:04.749191930 +0100
@@ -1 +1 @@
-From c60fad56266fef1f5f6e08c062806e137713e9da Mon Sep 17 00:00:00 2001
+From 033e89575192d23d38db7262021e4654379ec63c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c60fad56266fef1f5f6e08c062806e137713e9da ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- drivers/common/iavf/iavf_adminq.c | 3 ++-
+ drivers/net/iavf/base/iavf_adminq.c | 3 ++-
@@ -18,5 +19,5 @@
-diff --git a/drivers/common/iavf/iavf_adminq.c b/drivers/common/iavf/iavf_adminq.c
-index 8b305c0fe3..56c8a519be 100644
---- a/drivers/common/iavf/iavf_adminq.c
-+++ b/drivers/common/iavf/iavf_adminq.c
-@@ -788,7 +788,8 @@ enum iavf_status iavf_asq_send_command(struct iavf_hw *hw,
+diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c
+index a41402e04e..43483c0ee1 100644
+--- a/drivers/net/iavf/base/iavf_adminq.c
++++ b/drivers/net/iavf/base/iavf_adminq.c
+@@ -807,7 +807,8 @@ enum iavf_status_code iavf_asq_send_command(struct iavf_hw *hw,


More information about the stable mailing list