patch 'hash: fix RCU configuration memory leak' has been queued to stable release 20.11.7

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Nov 18 00:08:33 CET 2022


Hi,

FYI, your patch has been queued to stable release 20.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/19/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/9d8095a096ab6803748bac2472894655e0dc6e70

Thanks.

Luca Boccassi

---
>From 9d8095a096ab6803748bac2472894655e0dc6e70 Mon Sep 17 00:00:00 2001
From: Jun Qiu <jun.qiu at jaguarmicro.com>
Date: Fri, 4 Nov 2022 09:51:23 +0000
Subject: [PATCH] hash: fix RCU configuration memory leak

[ upstream commit bdd0c62c69b2b3c07e65d66daa7c564280e72480 ]

The memory of h->hash_rcu_cfg which is allocated in
rte_hash_rcu_qsbr_add was leaked.

Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")

Signed-off-by: Jun Qiu <jun.qiu at jaguarmicro.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 lib/librte_hash/rte_cuckoo_hash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
index 1191dfd81a..cff4242f79 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -527,6 +527,7 @@ rte_hash_free(struct rte_hash *h)
 	rte_free(h->buckets_ext);
 	rte_free(h->tbl_chng_cnt);
 	rte_free(h->ext_bkt_to_free);
+	rte_free(h->hash_rcu_cfg);
 	rte_free(h);
 	rte_free(te);
 }
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-17 23:07:55.897800690 +0000
+++ 0009-hash-fix-RCU-configuration-memory-leak.patch	2022-11-17 23:07:55.444329286 +0000
@@ -1 +1 @@
-From bdd0c62c69b2b3c07e65d66daa7c564280e72480 Mon Sep 17 00:00:00 2001
+From 9d8095a096ab6803748bac2472894655e0dc6e70 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bdd0c62c69b2b3c07e65d66daa7c564280e72480 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -15 +16 @@
- lib/hash/rte_cuckoo_hash.c | 1 +
+ lib/librte_hash/rte_cuckoo_hash.c | 1 +
@@ -18,5 +19,5 @@
-diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
-index 62c762439a..829b79c89a 100644
---- a/lib/hash/rte_cuckoo_hash.c
-+++ b/lib/hash/rte_cuckoo_hash.c
-@@ -521,6 +521,7 @@ rte_hash_free(struct rte_hash *h)
+diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
+index 1191dfd81a..cff4242f79 100644
+--- a/lib/librte_hash/rte_cuckoo_hash.c
++++ b/lib/librte_hash/rte_cuckoo_hash.c
+@@ -527,6 +527,7 @@ rte_hash_free(struct rte_hash *h)


More information about the stable mailing list