答复: patch 'net/bnxt: fix null pointer dereference in LED config' has been queued to stable release 21.11.3

[Mao,Yingming]

Hi Kevin,
I had received your email in 2022/10/25. Sorry for late reply. I have tested the following patch base dpdk20.11.6, it works ok.

https://github.com/kevintraynor/dpdk-stable/commit/d4774717275b47c291f8da09da17aea4deedd822

This patch should backport to dpdk 20.11. Please push it do dpdk LTS 20.11.
This patch dose not need to be backported and does not apply to 19.11

Regards,
Mao Yingming


-----邮件原件-----
发件人: Kevin Traynor <ktraynor at redhat.com> 
发送时间: 2022年10月25日 23:07
收件人: Mao,Yingming <maoyingming at baidu.com>
抄送: Somnath Kotur <somnath.kotur at broadcom.com>; Ajit Khaparde <ajit.khaparde at broadcom.com>; dpdk stable <stable at dpdk.org>
主题: patch 'net/bnxt: fix null pointer dereference in LED config' has been queued to stable release 21.11.3

Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/01/22. So please shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/d4774717275b47c291f8da09da17aea4deedd822

Thanks.

Kevin

---
From d4774717275b47c291f8da09da17aea4deedd822 Mon Sep 17 00:00:00 2001
From: Mao YingMing <maoyingming at baidu.com>
Date: Tue, 2 Aug 2022 12:08:17 +0800
Subject: [PATCH] net/bnxt: fix null pointer dereference in LED config

[ upstream commit 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 ]

For VFs, bp->leds is uninitialized, check bp->leds is not null before checking for bp->leds->num_leds.

segfault backtrace in trex program when use VF:
11: bnxt_hwrm_port_led_cfg (bp=0x23ffb2140, led_on=true)
10: bnxt_dev_led_on_op (dev=0x22d7780 <rte_eth_devices>)
 9: rte_eth_led_on (port_id=0)
 8: DpdkTRexPortAttr::set_led (this=0x23b6ce0, on=true)
 7: DpdkTRexPortAttr::DpdkTRexPortAttr
 6: CTRexExtendedDriverBnxt::create_port_attr
 5: CPhyEthIF::Create
 4: CGlobalTRex::device_start
 3: CGlobalTRex::Create
 2: main_test
 1: main

Fixes: d4d5a04 ("net/bnxt: fix unnecessary memory allocation")

Signed-off-by: Mao YingMing <maoyingming at baidu.com>
Acked-by: Somnath Kotur <somnath.kotur at broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 9c5257309a..51e1e2d6b3 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -4536,5 +4536,5 @@ int bnxt_hwrm_port_led_cfg(struct bnxt *bp, bool led_on)
 	int rc, i;
 
-	if (!bp->leds->num_leds || BNXT_VF(bp))
+	if (BNXT_VF(bp) || !bp->leds || !bp->leds->num_leds)
 		return -EOPNOTSUPP;
 
--
2.37.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-10-25 14:19:00.377396063 +0100
+++ 0081-net-bnxt-fix-null-pointer-dereference-in-LED-config.patch	2022-10-25 14:18:58.513798456 +0100
@@ -1 +1 @@
-From 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 Mon Sep 17 00:00:00 2001
+From d4774717275b47c291f8da09da17aea4deedd822 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4bfb499829fa2bf216e38e56aa313c1dceef6ed5 ]
+
@@ -23 +24,0 @@
-Cc: stable at dpdk.org