patch 'service: fix build with clang 15' has been queued to stable release 19.11.14

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Thu Nov 24 15:00:25 CET 2022


Hi,

FYI, your patch has been queued to stable release 19.11.14

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/9741b95a7978ada4d634fbcb1f8b7e19d974efc3

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 9741b95a7978ada4d634fbcb1f8b7e19d974efc3 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Fri, 18 Nov 2022 09:53:03 +0100
Subject: [PATCH] service: fix build with clang 15

[ upstream commit b41e574c2d2e8d82ec5e22a950e385c73efda850 ]

This variable is not used.

Bugzilla ID: 1130
Fixes: 21698354c832 ("service: introduce service cores concept")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
---
 lib/librte_eal/common/rte_service.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
index 11cd5a538d..4d21d1bdc3 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -101,14 +101,12 @@ rte_service_init(void)
 	}
 
 	int i;
-	int count = 0;
 	struct rte_config *cfg = rte_eal_get_configuration();
 	for (i = 0; i < RTE_MAX_LCORE; i++) {
 		if (lcore_config[i].core_role == ROLE_SERVICE) {
 			if ((unsigned int)i == cfg->master_lcore)
 				continue;
 			rte_service_lcore_add(i);
-			count++;
 		}
 	}
 
-- 
2.38.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-24 14:58:12.530732286 +0100
+++ 0002-service-fix-build-with-clang-15.patch	2022-11-24 14:58:11.805189452 +0100
@@ -1 +1 @@
-From b41e574c2d2e8d82ec5e22a950e385c73efda850 Mon Sep 17 00:00:00 2001
+From 9741b95a7978ada4d634fbcb1f8b7e19d974efc3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b41e574c2d2e8d82ec5e22a950e385c73efda850 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- lib/eal/common/rte_service.c | 2 --
+ lib/librte_eal/common/rte_service.c | 2 --
@@ -19,5 +20,5 @@
-diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
-index bcc2e19077..42ca1d001d 100644
---- a/lib/eal/common/rte_service.c
-+++ b/lib/eal/common/rte_service.c
-@@ -107,14 +107,12 @@ rte_service_init(void)
+diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
+index 11cd5a538d..4d21d1bdc3 100644
+--- a/lib/librte_eal/common/rte_service.c
++++ b/lib/librte_eal/common/rte_service.c
+@@ -101,14 +101,12 @@ rte_service_init(void)
@@ -31 +32 @@
- 			if ((unsigned int)i == cfg->main_lcore)
+ 			if ((unsigned int)i == cfg->master_lcore)


More information about the stable mailing list