patch 'test/efd: fix build with clang 15' has been queued to stable release 19.11.14

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Thu Nov 24 15:00:29 CET 2022


Hi,

FYI, your patch has been queued to stable release 19.11.14

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/9d04bda265085e6f6bcaed242f7c8c8f63cbc16f

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 9d04bda265085e6f6bcaed242f7c8c8f63cbc16f Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Fri, 18 Nov 2022 09:53:11 +0100
Subject: [PATCH] test/efd: fix build with clang 15

[ upstream commit 94ec062953778f986af4261c7f6eb31af7c84202 ]

This local variable hides the more global one.
The original intent was probably to use the global one.

Fixes: 0e925aef2779 ("app/test: add EFD functional and perf tests")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
---
 app/test/test_efd_perf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c
index c7d6e1e426..3ed4122b60 100644
--- a/app/test/test_efd_perf.c
+++ b/app/test/test_efd_perf.c
@@ -143,7 +143,6 @@ setup_keys_and_data(struct efd_perf_params *params, unsigned int cycle)
 		qsort(keys, KEYS_TO_ADD, MAX_KEYSIZE, key_compare);
 
 		/* Sift through the list of keys and look for duplicates */
-		int num_duplicates = 0;
 		for (i = 0; i < KEYS_TO_ADD - 1; i++) {
 			if (memcmp(keys[i], keys[i + 1], params->key_size) == 0) {
 				/* This key already exists, try again */
-- 
2.38.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-11-24 14:58:13.610749748 +0100
+++ 0006-test-efd-fix-build-with-clang-15.patch	2022-11-24 14:58:11.809189477 +0100
@@ -1 +1 @@
-From 94ec062953778f986af4261c7f6eb31af7c84202 Mon Sep 17 00:00:00 2001
+From 9d04bda265085e6f6bcaed242f7c8c8f63cbc16f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 94ec062953778f986af4261c7f6eb31af7c84202 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index d7f4d83549..4d04ed93e3 100644
+index c7d6e1e426..3ed4122b60 100644
@@ -22 +23 @@
-@@ -153,7 +153,6 @@ setup_keys_and_data(struct efd_perf_params *params, unsigned int cycle)
+@@ -143,7 +143,6 @@ setup_keys_and_data(struct efd_perf_params *params, unsigned int cycle)


More information about the stable mailing list