[PATCH 05/35] net/ionic: fix up reported error stats
Andrew Boyer
andrew.boyer at amd.com
Fri Oct 7 19:43:06 CEST 2022
Report descriptor errors in ierrors instead of imissed.
Don't report rx_queue_empty or rx_queue_disabled in imissed,
since those packet errors are already included in the
rx_*_drop_packets counters.
This makes the reported stats correct.
Fixes: 3cdfd90579e7 ("net/ionic: add stats")
Cc: cardigliano at ntop.org
Cc: stable at dpdk.org
Signed-off-by: Andrew Boyer <andrew.boyer at amd.com>
---
drivers/net/ionic/ionic_lif.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c
index 5e8fdf3893..799530f7f5 100644
--- a/drivers/net/ionic/ionic_lif.c
+++ b/drivers/net/ionic/ionic_lif.c
@@ -132,7 +132,7 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats
for (i = 0; i < lif->nrxqcqs; i++) {
struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats;
- stats->imissed +=
+ stats->ierrors +=
rx_stats->no_cb_arg +
rx_stats->bad_cq_status +
rx_stats->no_room +
@@ -144,10 +144,8 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats
ls->rx_mcast_drop_packets +
ls->rx_bcast_drop_packets;
- stats->imissed +=
- ls->rx_queue_empty +
+ stats->ierrors +=
ls->rx_dma_error +
- ls->rx_queue_disabled +
ls->rx_desc_fetch_error +
ls->rx_desc_data_error;
--
2.17.1
More information about the stable
mailing list