[EXT] [PATCH v2 3/9] trace: fix leak with regexp
Sunil Kumar Kori
skori at marvell.com
Wed Oct 12 11:10:02 CEST 2022
> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Tuesday, October 4, 2022 3:14 PM
> To: dev at dpdk.org
> Cc: skori at mavell.com; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> stable at dpdk.org; Sunil Kumar Kori <skori at marvell.com>
> Subject: [EXT] [PATCH v2 3/9] trace: fix leak with regexp
>
> External Email
>
> ----------------------------------------------------------------------
> The precompiled buffer initialised in regcomp must be freed before leaving
> rte_trace_regexp.
>
> Fixes: 84c4fae4628f ("trace: implement operation APIs")
> Cc: stable at dpdk.org
>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
> Changes since v1:
> - split patch in two, keeping only the backportable fix as patch 3,
>
> ---
> lib/eal/common/eal_common_trace.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Acked-by: Sunil Kumar Kori <skori at marvell.com>
> diff --git a/lib/eal/common/eal_common_trace.c
> b/lib/eal/common/eal_common_trace.c
> index 1b86f5d2d2..1db11e3e14 100644
> --- a/lib/eal/common/eal_common_trace.c
> +++ b/lib/eal/common/eal_common_trace.c
> @@ -218,8 +218,10 @@ rte_trace_regexp(const char *regex, bool enable)
> rc = rte_trace_point_disable(tp->handle);
> found = 1;
> }
> - if (rc < 0)
> - return rc;
> + if (rc < 0) {
> + found = 0;
> + break;
> + }
> }
> regfree(&r);
>
> --
> 2.37.3
More information about the stable
mailing list