[PATCH] net/bonding: fix flow flush order on bonded device close
Chas Williams
3chas3 at gmail.com
Mon Oct 17 14:34:02 CEST 2022
This appears to be correct, but it needs to be coordinated with the
proposed changes in net/bonding: make bonded device configure method re-entrant
On 10/17/22 04:41, Andrew Rybchenko wrote:
> Chas, Cornor, could you review the patch, please.
>
> Thanks,
> Andrew.
>
> On 9/11/22 15:22, Ivan Malov wrote:
>> The current code first removes all back-end devices of
>> the bonded device and then invokes flush operation to
>> remove flows in such back-end devices, which makes no
>> sense. Fix that by re-ordering the steps accordingly.
>>
>> Fixes: 49dad9028e2a ("net/bonding: support flow API")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
>> ---
>> drivers/net/bonding/rte_eth_bond_pmd.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
>> b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index a5429f5e97..d01c954296 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -2155,6 +2155,10 @@ bond_ethdev_close(struct rte_eth_dev *dev)
>> return 0;
>> RTE_BOND_LOG(INFO, "Closing bonded device %s", dev->device->name);
>> +
>> + /* Flush flows in all back-end devices before removing them */
>> + bond_flow_ops.flush(dev, &ferror);
>> +
>> while (internals->slave_count != skipped) {
>> uint16_t port_id = internals->slaves[skipped].port_id;
>> @@ -2172,7 +2176,6 @@ bond_ethdev_close(struct rte_eth_dev *dev)
>> skipped++;
>> }
>> }
>> - bond_flow_ops.flush(dev, &ferror);
>> bond_ethdev_free_queues(dev);
>> rte_bitmap_reset(internals->vlan_filter_bmp);
>> rte_bitmap_free(internals->vlan_filter_bmp);
>
More information about the stable
mailing list