[PATCH] net/bonding: fix descriptor limit reporting

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Mon Oct 17 16:08:06 CEST 2022


On 10/17/22 15:40, Chas Williams wrote:
> On 10/17/22 04:40, Andrew Rybchenko wrote:
>> Chas, Cornor, could you review the patch, please.
>>
>> Thanks,
>> Andrew.
>>
>> On 9/11/22 15:19, Ivan Malov wrote:
>>> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
>>> breaks reporting of "nb_min" and "nb_align" values obtained from
>>> back-end devices' descriptor limits. This means that work done
>>> by eth_bond_slave_inherit_desc_lim_first() as well as
>>> eth_bond_slave_inherit_desc_lim_next() gets dismissed.
>>>
>>> Revert the offending commit and use proper workaround
>>> for the test case mentioned in the said commit.
>>>
>>> Meanwhile, the test case itself might be poorly constructed.
>>> It tries to run a bond with no back-end devices attached,
>>> but, according to [1] ("Requirements / Limitations"),
>>> at least one back-end device must be attached.
>>>
>>> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
>>>
>>> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
>>> Cc: stable at dpdk.org
>>>
>>> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
>>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
 >
 > Acked-by: Chas Williams <3chas3 at gmail.com>

Applied to dpdk-next-net/main, thanks.



More information about the stable mailing list