patch 'test/ipsec: skip if no compatible device' has been queued to stable release 21.11.3

Kevin Traynor ktraynor at redhat.com
Tue Oct 25 17:06:26 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/01/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb

Thanks.

Kevin

---
>From 6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb Mon Sep 17 00:00:00 2001
From: Jeremy Spewock <jspewock at iol.unh.edu>
Date: Tue, 12 Jul 2022 10:17:01 -0400
Subject: [PATCH] test/ipsec: skip if no compatible device

[ upstream commit 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 ]

ipsec_autotest is now skipped if no compatible crypto devices are found.

Fixes issue where if at least one crypto device was found but no
compatible crypto devices for the ipsec_autotest test case are present,
the case would fail with no error message. Now, when this situation is
encountered, the test case will be skipped with an explanation.

Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup")

Signed-off-by: Jeremy Spewock <jspewock at iol.unh.edu>
Signed-off-by: Owen Hilyard <ohilyard at iol.unh.edu>
Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
---
 app/test/test_ipsec.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index 3c6dcdc604..6d5431843f 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -310,6 +310,8 @@ testsuite_setup(void)
 	}
 
-	if (ts_params->valid_dev_found == 0)
-		return TEST_FAILED;
+	if (ts_params->valid_dev_found == 0) {
+		RTE_LOG(WARNING, USER1, "No compatible crypto device found.\n");
+		return TEST_SKIPPED;
+	}
 
 	ts_params->mbuf_pool = rte_pktmbuf_pool_create(
-- 
2.37.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-10-25 14:18:59.248242872 +0100
+++ 0031-test-ipsec-skip-if-no-compatible-device.patch	2022-10-25 14:18:58.385797998 +0100
@@ -1 +1 @@
-From 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 Mon Sep 17 00:00:00 2001
+From 6a5ed8de57f7c4532abb61f2f4bb31ee70d141bb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 37edccf8f79d7a8d0cbb00907a93ec9b9f476ed3 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 7047e17960..7c03a06785 100644
+index 3c6dcdc604..6d5431843f 100644
@@ -27 +28 @@
-@@ -321,6 +321,8 @@ testsuite_setup(void)
+@@ -310,6 +310,8 @@ testsuite_setup(void)



More information about the stable mailing list