patch 'net/bnxt: fix error code during MTU change' has been queued to stable release 21.11.3

Kevin Traynor ktraynor at redhat.com
Tue Oct 25 17:07:17 CEST 2022


Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/01/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a12a1fcc0c38e8694d1abe3252c2e8b83605fec9

Thanks.

Kevin

---
>From a12a1fcc0c38e8694d1abe3252c2e8b83605fec9 Mon Sep 17 00:00:00 2001
From: Benjamin Le Berre <benjamin.le_berre at 6wind.com>
Date: Thu, 15 Sep 2022 13:29:06 +0200
Subject: [PATCH] net/bnxt: fix error code during MTU change

[ upstream commit 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 ]

When the BNXT PMD was made to disallow MTU changes on active ports, the
error code chosen for the case in bnxt_set_mtu_op() was -EPERM.

The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h
lists -EBUSY as the value to be used if the port must be stopped before
applying an MTU change and does not list -EPERM as a possible return
value.

This patch makes bnxt_set_mtu_op() return -EBUSY instead of -EPERM so
that rte_eth_dev_set_mtu() behaves as expected.

Fixes: a42ab1eb33ff ("net/bnxt: disallow MTU change when device is started")

Signed-off-by: Benjamin Le Berre <benjamin.le_berre at 6wind.com>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 517e4b3898..5c9a260db5 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3032,5 +3032,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
 	if (eth_dev->data->dev_started) {
 		PMD_DRV_LOG(ERR, "Stop port before changing MTU\n");
-		return -EPERM;
+		return -EBUSY;
 	}
 
-- 
2.37.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-10-25 14:19:00.401026048 +0100
+++ 0082-net-bnxt-fix-error-code-during-MTU-change.patch	2022-10-25 14:18:58.517798471 +0100
@@ -1 +1 @@
-From 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 Mon Sep 17 00:00:00 2001
+From a12a1fcc0c38e8694d1abe3252c2e8b83605fec9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 09b5b2880d58d256eb23cf5bb19cc9923e78b8e1 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -27 +28 @@
-index 1460dce2ab..c4d863e3fe 100644
+index 517e4b3898..5c9a260db5 100644
@@ -30 +31 @@
-@@ -3031,5 +3031,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
+@@ -3032,5 +3032,5 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)



More information about the stable mailing list