patch 'common/sfc_efx/base: remove VQ index check during VQ start' has been queued to stable release 21.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/01/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/84cc72849a59db523b69e322a84a4d879032ceb1

Thanks.

Kevin

---
>From 84cc72849a59db523b69e322a84a4d879032ceb1 Mon Sep 17 00:00:00 2001
From: Abhimanyu Saini <absaini at amd.com>
Date: Thu, 14 Jul 2022 19:18:00 +0530
Subject: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start

[ upstream commit 93211a52a65f3f9c4280155ce7bd12a11c48ffdb ]

The used/avail queue indexes are not bound by queue size,
because HW calculates descriptor entry index by performing
a simple modulo between queue index and queue_size.

So, do not check initial used and avail queue indexes
against queue size because it is possible for these
indexes to be greater than queue size in the
following cases:
1) The queue is created to be migrated into, or
2) The client issues a qstop/qstart after running datapath

Fixes: 4dda72dbdeab3 ("common/sfc_efx/base: add base virtio support for vDPA")

Signed-off-by: Abhimanyu Saini <absaini at amd.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 drivers/common/sfc_efx/base/rhead_virtio.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/common/sfc_efx/base/rhead_virtio.c b/drivers/common/sfc_efx/base/rhead_virtio.c
index 335cb747d1..7f087170fe 100644
--- a/drivers/common/sfc_efx/base/rhead_virtio.c
+++ b/drivers/common/sfc_efx/base/rhead_virtio.c
@@ -48,12 +48,4 @@ rhead_virtio_qstart(
 	}
 
-	if (evvdp != NULL) {
-		if ((evvdp->evvd_vq_cidx > evvcp->evvc_vq_size) ||
-		    (evvdp->evvd_vq_pidx > evvcp->evvc_vq_size)) {
-			rc = EINVAL;
-			goto fail3;
-		}
-	}
-
 	req.emr_cmd = MC_CMD_VIRTIO_INIT_QUEUE;
 	req.emr_in_buf = payload;
@@ -117,5 +109,5 @@ rhead_virtio_qstart(
 	if (req.emr_rc != 0) {
 		rc = req.emr_rc;
-		goto fail4;
+		goto fail3;
 	}
 
@@ -124,6 +116,4 @@ rhead_virtio_qstart(
 	return (0);
 
-fail4:
-	EFSYS_PROBE(fail4);
 fail3:
 	EFSYS_PROBE(fail3);
-- 
2.37.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-10-25 14:19:00.664254730 +0100
+++ 0094-common-sfc_efx-base-remove-VQ-index-check-during-VQ-.patch	2022-10-25 14:18:58.536798539 +0100
@@ -1 +1 @@
-From 93211a52a65f3f9c4280155ce7bd12a11c48ffdb Mon Sep 17 00:00:00 2001
+From 84cc72849a59db523b69e322a84a4d879032ceb1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 93211a52a65f3f9c4280155ce7bd12a11c48ffdb ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org