[PATCH v2] examples/distributor: update dynamic configuration
Hunt, David
david.hunt at intel.com
Thu Sep 1 12:58:01 CEST 2022
Hi Ömer,
On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer
Yamaç) wrote:
> In this patch,
> * It is possible to switch the running mode of the distributor
> using the command line argument.
> * With "-c" parameter, you can run RX and Distributor
> on the same core.
> * Without "-c" parameter, you can run RX and Distributor
> on the different core.
> * Syntax error of the single RX and distributor core is fixed.
I believe this particular fix is already merged and back-ported to
stable. No need to include this line in the commit message.
> * Consecutive termination of the lcores fixed.
> The termination order was wrong, and you couldn't terminate the
> application while traffic was capturing. The current order is
> RX -> Distributor -> TX -> Workers
> * When "-c" parameter is active, the wasted distributor core is
> also deactivated in the main function.
>
> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
> Cc: stable at dpdk.org
This is a feature change, not a fix, so I don't believe you need the
"Fixes" line or the "Cc: stable" line.
>
> Signed-off-by: Abdullah ?mer Yama? <omer.yamac at ceng.metu.edu.tr>
I've tested this with the "-c" option, works well. Traffic coming into
the app is distributed among the core. With -c added to the command line
parameters, I have an extra worker core, as expected. Looks good to me.
With the above suggested changes to the commit message:
Reviewed-by: David Hunt <david.hunt at intel.com>
More information about the stable
mailing list