[EXT] Re: [PATCH v2] vhost: compilation fix for GCC-12

Amit Prakash Shukla amitprakashs at marvell.com
Fri Sep 2 17:11:47 CEST 2022


Thanks for the feedback.

> -----Original Message-----
> From: Bagas Sanjaya <bagasdotme at gmail.com>
> Sent: Friday, September 2, 2022 6:26 PM
> To: Amit Prakash Shukla <amitprakashs at marvell.com>
> Cc: Maxime Coquelin <maxime.coquelin at redhat.com>; Chenbo Xia
> <chenbo.xia at intel.com>; dev at dpdk.org; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; stable at dpdk.org; Ruifeng.Wang at arm.com
> Subject: [EXT] Re: [PATCH v2] vhost: compilation fix for GCC-12
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Fri, Sep 02, 2022 at 06:11:52PM +0530, Amit Prakash Shukla wrote:
> > ../lib/vhost/virtio_net.c:941:35: error:
> > 		'buf_vec[0].buf_len' may be used uninitialized
> > 		[-Werror=maybe-uninitialized]
> >   941 |         buf_len = buf_vec[vec_idx].buf_len;
> >       |                   ~~~~~~~~~~~~~~~~^~~~~~~~
> > ../lib/vhost/virtio_net.c: In function 'virtio_dev_rx_packed':
> > ../lib/vhost/virtio_net.c:1285:27: note: 'buf_vec' declared here
> >  1285 |         struct buf_vector buf_vec[BUF_VECTOR_MAX];
> >       |                           ^~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Fixes: 93520085efda ("vhost: add packed ring single enqueue")
> > Cc: stable at dpdk.org
> 
> Please describe what this patch is doing (the current state of code, why it
> errored, and how it is fixing the error). Write the description in imperative
> mood. I don't see the description other than error message above.
I have pushed v3 incorporating your suggestion regarding description.

> 
> Also, for stable patches submission, Cc stable at vger.kernel.org.
> 
> Thanks.
> 
> --
> An old man doll... just what I always wanted! - Clara


More information about the stable mailing list