[PATCH 2/8] trace: fix mode change
David Marchand
david.marchand at redhat.com
Wed Sep 21 14:03:53 CEST 2022
The API does not state that changing mode should be refused if no trace
point is enabled. Remove this limitation.
Fixes: 84c4fae4628f ("trace: implement operation APIs")
Cc: stable at dpdk.org
Signed-off-by: David Marchand <david.marchand at redhat.com>
---
app/test/test_trace.c | 3 ---
lib/eal/common/eal_common_trace.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/app/test/test_trace.c b/app/test/test_trace.c
index 76af79162b..44ac38a4fa 100644
--- a/app/test/test_trace.c
+++ b/app/test/test_trace.c
@@ -126,9 +126,6 @@ test_trace_mode(void)
current = rte_trace_mode_get();
- if (!rte_trace_is_enabled())
- return TEST_SKIPPED;
-
rte_trace_mode_set(RTE_TRACE_MODE_DISCARD);
if (rte_trace_mode_get() != RTE_TRACE_MODE_DISCARD)
goto failed;
diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c
index f3ae4f7922..1db28a441d 100644
--- a/lib/eal/common/eal_common_trace.c
+++ b/lib/eal/common/eal_common_trace.c
@@ -126,9 +126,6 @@ rte_trace_mode_set(enum rte_trace_mode mode)
{
struct trace_point *tp;
- if (!rte_trace_is_enabled())
- return;
-
STAILQ_FOREACH(tp, &tp_list, next)
trace_mode_set(tp->handle, mode);
--
2.37.3
More information about the stable
mailing list