[PATCH] app/test: fix LACP handshake overtime

humin (Q) humin29 at huawei.com
Fri Sep 23 02:58:14 CEST 2022


Hi, Zhang,

     Why LACP handshake "overtime" in your test?

     Maybe in other occasions, 60 * delay is also not enough.

     BTW, how about config "conf.update_timeout_ms" for the test?

在 2022/8/18 13:43, Ke Zhang 写道:
> Increase the loop count so that there is a longer
> threshold time for the LACP handshake process.
>
> Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4")
> Cc: stable at dpdk.org
>
> Signed-off-by: Ke Zhang <ke1x.zhang at intel.com>
> ---
>   app/test/test_link_bonding_mode4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c
> index d9b9c323c7..bfdd18cdd1 100644
> --- a/app/test/test_link_bonding_mode4.c
> +++ b/app/test/test_link_bonding_mode4.c
> @@ -613,7 +613,7 @@ bond_handshake(void)
>   
>   	/* Exchange LACP frames */
>   	all_slaves_done = 0;
> -	for (i = 0; i < 30 && all_slaves_done == 0; ++i) {
> +	for (i = 0; i < 60 && all_slaves_done == 0; ++i) {
>   		rte_delay_ms(delay);
>   
>   		all_slaves_done = 1;


More information about the stable mailing list