patch 'test/bbdev: remove check for invalid opaque data' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Sun Apr 9 17:23:23 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/47cef6560020c12c8c8dbba4b97df4fcda5a69ed

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 47cef6560020c12c8c8dbba4b97df4fcda5a69ed Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Thu, 2 Mar 2023 12:21:57 -0800
Subject: [PATCH] test/bbdev: remove check for invalid opaque data
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 26437807ff57a13133d4c03d87c5eac037f1ffaa ]

Assert also if the opaque data is invalid.

Fixes: 335c11fd2763 ("app/bbdev: support HARQ validation")

Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 app/test-bbdev/test_bbdev_perf.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 2f15bf6fe8..0f441ace4d 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -78,7 +78,6 @@
 
 #define SYNC_WAIT 0
 #define SYNC_START 1
-#define INVALID_OPAQUE -1
 
 #define INVALID_QUEUE_ID -1
 /* Increment for next code block in external HARQ memory */
@@ -1953,10 +1952,9 @@ check_enc_status_and_ordering(struct rte_bbdev_enc_op *op,
 			"op_status (%d) != expected_status (%d)",
 			op->status, expected_status);
 
-	if (op->opaque_data != (void *)(uintptr_t)INVALID_OPAQUE)
-		TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data,
-				"Ordering error, expected %p, got %p",
-				(void *)(uintptr_t)order_idx, op->opaque_data);
+	TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data,
+			"Ordering error, expected %p, got %p",
+			(void *)(uintptr_t)order_idx, op->opaque_data);
 
 	return TEST_SUCCESS;
 }
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-04-09 21:45:39.222437900 +0800
+++ 0015-test-bbdev-remove-check-for-invalid-opaque-data.patch	2023-04-09 21:45:38.599042200 +0800
@@ -1 +1 @@
-From 26437807ff57a13133d4c03d87c5eac037f1ffaa Mon Sep 17 00:00:00 2001
+From 47cef6560020c12c8c8dbba4b97df4fcda5a69ed Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 26437807ff57a13133d4c03d87c5eac037f1ffaa ]
@@ -9 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +20 @@
-index 74e7e13940..95d63a3548 100644
+index 2f15bf6fe8..0f441ace4d 100644
@@ -29 +31 @@
-@@ -1951,10 +1950,9 @@ check_enc_status_and_ordering(struct rte_bbdev_enc_op *op,
+@@ -1953,10 +1952,9 @@ check_enc_status_and_ordering(struct rte_bbdev_enc_op *op,


More information about the stable mailing list