patch 'table: fix action selector group size log2 setting' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Sun Apr 9 17:24:10 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/cb4baf72a46b98fc6110a6382c299f11005afab6

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From cb4baf72a46b98fc6110a6382c299f11005afab6 Mon Sep 17 00:00:00 2001
From: Yogesh Jangra <yogesh.jangra at intel.com>
Date: Thu, 9 Mar 2023 13:58:42 +0000
Subject: [PATCH] table: fix action selector group size log2 setting
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ]

The incorrect variable for the number of groups was used, so in the
case of values not power of 2 the incorrect result was produced.

Fixes: f7598a62d114 ("table: support selector table")

Signed-off-by: Yogesh Jangra <yogesh.jangra at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 lib/table/rte_swx_table_selector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_selector.c b/lib/table/rte_swx_table_selector.c
index ad99f18453..18e021fe6f 100644
--- a/lib/table/rte_swx_table_selector.c
+++ b/lib/table/rte_swx_table_selector.c
@@ -232,7 +232,7 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params)
 	t->params.n_members_per_group_max = rte_align32pow2(params->n_members_per_group_max);
 
 	for (i = 0; i < 32; i++)
-		if (params->n_members_per_group_max == 1U << i)
+		if (t->params.n_members_per_group_max == 1U << i)
 			t->n_members_per_group_max_log2 = i;
 
 	/* t->params.selector_mask */
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-04-09 21:45:40.371580900 +0800
+++ 0062-table-fix-action-selector-group-size-log2-setting.patch	2023-04-09 21:45:38.669042200 +0800
@@ -1 +1 @@
-From 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 Mon Sep 17 00:00:00 2001
+From cb4baf72a46b98fc6110a6382c299f11005afab6 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list