patch 'app/bbdev: check statistics failure' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Sun Apr 9 17:24:56 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/b80c949b77809e9c7026af726a0a878c0a43c278

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From b80c949b77809e9c7026af726a0a878c0a43c278 Mon Sep 17 00:00:00 2001
From: Hernan Vargas <hernan.vargas at intel.com>
Date: Wed, 8 Mar 2023 19:36:24 -0800
Subject: [PATCH] app/bbdev: check statistics failure
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ]

Add check for return value from get_bbdev_queue_stats.

Coverity issue: 383155
Fixes: c25604355a15 ("app/bbdev: add explicit check for counters")

Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 app/test-bbdev/test_bbdev_perf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 0f441ace4d..f77ebc4b47 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -5382,7 +5382,7 @@ offload_cost_test(struct active_device *ad,
 	printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n");
 	return TEST_SKIPPED;
 #else
-	int iter;
+	int iter, ret;
 	uint16_t burst_sz = op_params->burst_sz;
 	const uint16_t num_to_process = op_params->num_to_process;
 	const enum rte_bbdev_op_type op_type = test_vector.op_type;
@@ -5477,7 +5477,10 @@ offload_cost_test(struct active_device *ad,
 			rte_get_tsc_hz());
 
 	struct rte_bbdev_stats stats = {0};
-	get_bbdev_queue_stats(ad->dev_id, queue_id, &stats);
+	ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats);
+	TEST_ASSERT_SUCCESS(ret,
+			"Failed to get stats for queue (%u) of device (%u)",
+			queue_id, ad->dev_id);
 	if (op_type != RTE_BBDEV_OP_LDPC_DEC) {
 		TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process,
 				"Mismatch in enqueue count %10"PRIu64" %d",
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-04-09 21:45:41.548782800 +0800
+++ 0108-app-bbdev-check-statistics-failure.patch	2023-04-09 21:45:38.759042200 +0800
@@ -1 +1 @@
-From ce1b62899167f6e2c49d8496afa43a9162167c6b Mon Sep 17 00:00:00 2001
+From b80c949b77809e9c7026af726a0a878c0a43c278 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index 15ebcdfc15..276bbf0a2e 100644
+index 0f441ace4d..f77ebc4b47 100644
@@ -22,4 +24,4 @@
-@@ -5679,7 +5679,7 @@ static int
- offload_cost_test(struct active_device *ad,
- 		struct test_op_params *op_params)
- {
+@@ -5382,7 +5382,7 @@ offload_cost_test(struct active_device *ad,
+ 	printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n");
+ 	return TEST_SKIPPED;
+ #else
@@ -31 +33 @@
-@@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad,
+@@ -5477,7 +5477,10 @@ offload_cost_test(struct active_device *ad,
@@ -40,3 +42,3 @@
- 	if (stats.enqueue_warn_count > 0)
- 		printf("Warning reported on the queue : %10"PRIu64"\n",
- 			stats.enqueue_warn_count);
+ 	if (op_type != RTE_BBDEV_OP_LDPC_DEC) {
+ 		TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process,
+ 				"Mismatch in enqueue count %10"PRIu64" %d",


More information about the stable mailing list