patch 'net/mlx5/hws: fix error code of send queue action' has been queued to stable release 22.11.2

Xueming Li xuemingl at nvidia.com
Sun Apr 9 17:25:19 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/1f4de71406e27229e0e941a196605490e2de4aed

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 1f4de71406e27229e0e941a196605490e2de4aed Mon Sep 17 00:00:00 2001
From: Alex Vesker <valex at nvidia.com>
Date: Thu, 23 Mar 2023 14:34:14 +0200
Subject: [PATCH] net/mlx5/hws: fix error code of send queue action
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 8ae49a5edb5b1a64716b00bd644c57278d1801fe ]

The rte_errno should be set to a positive error value
while the ret of the function should return a negative
value this aligns code to other mlx5dr API functions.

Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")

Signed-off-by: Alex Vesker <valex at nvidia.com>
Reviewed-by: Erez Shitrit <erezsh at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_send.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c
index 5c8bbe6fc6..a8aba31cbe 100644
--- a/drivers/net/mlx5/hws/mlx5dr_send.c
+++ b/drivers/net/mlx5/hws/mlx5dr_send.c
@@ -842,8 +842,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx,
 			/* Signal on the last posted WQE */
 			mlx5dr_send_engine_flush_queue(queue);
 	} else {
-		rte_errno = -EINVAL;
-		return rte_errno;
+		rte_errno = EINVAL;
+		return -rte_errno;
 	}
 
 	return 0;
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-04-09 21:45:42.115619200 +0800
+++ 0131-net-mlx5-hws-fix-error-code-of-send-queue-action.patch	2023-04-09 21:45:38.809042200 +0800
@@ -1 +1 @@
-From 8ae49a5edb5b1a64716b00bd644c57278d1801fe Mon Sep 17 00:00:00 2001
+From 1f4de71406e27229e0e941a196605490e2de4aed Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8ae49a5edb5b1a64716b00bd644c57278d1801fe ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index 51aaf5c8e2..d650c55124 100644
+index 5c8bbe6fc6..a8aba31cbe 100644
@@ -24,4 +26,4 @@
-@@ -1007,8 +1007,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx,
- 
- 		break;
- 	default:
+@@ -842,8 +842,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx,
+ 			/* Signal on the last posted WQE */
+ 			mlx5dr_send_engine_flush_queue(queue);
+ 	} else {


More information about the stable mailing list