patch 'net/nfp: fix IPv6 address for set flow action' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Thu Aug 10 01:47:33 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=a5260630921d771535853462bda8bd0b450e2102

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From a5260630921d771535853462bda8bd0b450e2102 Mon Sep 17 00:00:00 2001
From: Chaoyong He <chaoyong.he at corigine.com>
Date: Mon, 12 Jun 2023 10:24:24 +0800
Subject: [PATCH] net/nfp: fix IPv6 address for set flow action
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 63f3184382794e19e8be9a0c88aebb55d5f13626 ]

The former logic of set IPv6 source/destination address flow action
can't get the right IPV6 address, a 32 bit big endian value is
expected while a 8 bit value is provided.
This caused the offloaded packets don't have the right IPv6 address
as expected.

Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action")
Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action")

Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
---
 drivers/net/nfp/nfp_flow.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index 1700aeec9d..194a5c63c5 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -2154,6 +2154,7 @@ nfp_flow_action_set_ipv6(char *act_data,
 		bool ip_src_flag)
 {
 	int i;
+	rte_be32_t tmp;
 	size_t act_size;
 	struct nfp_fl_act_set_ipv6_addr *set_ip;
 	const struct rte_flow_action_set_ipv6 *set_ipv6;
@@ -2171,7 +2172,8 @@ nfp_flow_action_set_ipv6(char *act_data,
 	set_ip->reserved = 0;
 
 	for (i = 0; i < 4; i++) {
-		set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i * 4];
+		rte_memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4);
+		set_ip->ipv6[i].exact = tmp;
 		set_ip->ipv6[i].mask = RTE_BE32(0xffffffff);
 	}
 }
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-08-09 21:51:18.579336300 +0800
+++ 0011-net-nfp-fix-IPv6-address-for-set-flow-action.patch	2023-08-09 21:51:18.124352000 +0800
@@ -1 +1 @@
-From 63f3184382794e19e8be9a0c88aebb55d5f13626 Mon Sep 17 00:00:00 2001
+From a5260630921d771535853462bda8bd0b450e2102 Mon Sep 17 00:00:00 2001
@@ -7,0 +8,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 63f3184382794e19e8be9a0c88aebb55d5f13626 ]
@@ -17 +19,0 @@
-Cc: stable at dpdk.org
@@ -26 +28 @@
-index 14749f03a2..4ba49a9b49 100644
+index 1700aeec9d..194a5c63c5 100644
@@ -29 +31 @@
-@@ -2164,6 +2164,7 @@ nfp_flow_action_set_ipv6(char *act_data,
+@@ -2154,6 +2154,7 @@ nfp_flow_action_set_ipv6(char *act_data,
@@ -37 +39 @@
-@@ -2181,7 +2182,8 @@ nfp_flow_action_set_ipv6(char *act_data,
+@@ -2171,7 +2172,8 @@ nfp_flow_action_set_ipv6(char *act_data,


More information about the stable mailing list